fix(native): Initialize null transport in crash daemon - #2048
Closed
jpnurmi wants to merge 1 commit into
Closed
Conversation
Null transport builds have no request to signal that crash processing finished. Keep the daemon completion marker available when debug logging is disabled so callers can wait for a successful shutdown.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2048 +/- ##
=======================================
Coverage 74.37% 74.37%
=======================================
Files 103 103
Lines 26665 26665
Branches 4852 4852
=======================================
+ Hits 19832 19833 +1
+ Misses 5501 5493 -8
- Partials 1332 1339 +7 🚀 New features to boost your workflow:
|
jpnurmi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon constructs options without calling
sentry_init(), so builds withSENTRY_TRANSPORT=noneleave the transport pointer unset. Install the internal null transport so crash processing completes without leaving stale envelopes on disk.