Skip to content

chore(asyncpg): Remove transaction-based tracing - #7192

Open
sentrivana wants to merge 6 commits into
major/3.0from
ivana/major/remove-transactions-asyncpg
Open

chore(asyncpg): Remove transaction-based tracing#7192
sentrivana wants to merge 6 commits into
major/3.0from
ivana/major/remove-transactions-asyncpg

Conversation

@sentrivana

@sentrivana sentrivana commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Use Hide whitespace ✨

CI (mypy) will be green after #7199, which removes transactions from some shared utils, is merged.

Closes PY-2681
Closes #7077

@linear-code

linear-code Bot commented Aug 13, 2026

Copy link
Copy Markdown

PY-2681

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

106975 passed | ❌ 1 failed | ⏭️ 5338 skipped | Total: 112314 | Pass Rate: 95.25% | Execution Time: 354m 56s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -13915
Passed Tests 📉 -12492
Failed Tests 📈 +1
Skipped Tests 📉 -1424

➕ New Tests (1)

View new tests
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[gevent]
    • File: tests.profiler.test_continuous_profiler
    • Status: ❌ Failing

❌ Failed Tests

test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[gevent]

File: tests.profiler.test_continuous_profiler
Suite: py3.7-gevent
Error: AssertionError: profiler should not be running assert 'f255fd1faaad42669a753f1623bf41c8' is None + where 'f255fd1faaad42669a753f1623bf41c8' = get_profiler_id()

Stack Trace
tests/profiler/test_continuous_profiler.py:693: in test_continuous_profiler_auto_start_and_stop_sampled_span_streaming
    assert get_profiler_id() is None, "profiler should not be running"
E   AssertionError: profiler should not be running
E   assert 'f255fd1faaad42669a753f1623bf41c8' is None
E    +  where 'f255fd1faaad42669a753f1623bf41c8' = get_profiler_id()

✅ Patch coverage is 84.62%. Project has 2242 uncovered lines.
✅ Project coverage is 90.5%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/asyncpg.py 84.62% ⚠️ 4 Missing and 4 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.30%    90.50%     +0.2%
==========================================
  Files          193       185        -8
  Lines        25612     23606     -2006
  Branches      9450      8678      -772
==========================================
+ Hits         23129     21364     -1765
- Misses        2483      2242      -241
- Partials      1434      1367       -67

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review August 31, 2026 14:08
@sentrivana
sentrivana requested a review from a team as a code owner August 31, 2026 14:08
@sentrivana
sentrivana marked this pull request as draft August 31, 2026 14:14
@sentrivana
sentrivana marked this pull request as ready for review August 31, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants