Repository navigation
ref(starlette): Remove unused _serialize_request_body_data helper - #8146
Merged
Merged
Conversation
sentrivana
approved these changes
Oct 29, 2026
pabloDeputter
approved these changes
Oct 29, 2026
Contributor
Coverage Results 📊✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 461m 33s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #8146 +/-##
==========================================
+ Coverage 90.28% 90.32% +0.04%
==========================================
Files 203 203 —
Tracked lines 26883 26877 -6
Branches 10046 10044 -2
==========================================
+ Hits 24272 24276 +4
+ Misses 2611 2601 -10
- Partials 1518 1520 +2Generated by Coverage Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
_serialize_request_body_datafromsentry_sdk/integrations/starlette.py. Nothing calls it.It was added in #6136 to serialize the request body for the segment span under span streaming. #6286 changed the FastAPI path to serialize the cached
request._json/request._formdirectly and removed the only call site (_serialize_request_body_data(info["data"])). The definition stayed behind.Why it's safe:
sentry_sdk/,tests/,scripts/, or docs.jsonandAnnotatedValueimports elsewhere, so this change doesn't remove any imports.via automation
sched_65eed06cc199036c2b13411096f412d4· Run IDsched_65eed06cc199036c2b13411096f412d4:1793267486380.--
View Junior Session [Sentry]