Repository navigation
test: give the playmode integration tests 5 s to receive an event - #2906
Draft
bitsandfoxes wants to merge 1 commit into
Draft
bitsandfoxes wants to merge 1 commit into
bitsandfoxes wants to merge 1 commit into
Conversation
bitsandfoxes
force-pushed
the
ci/job-timeouts
branch
from
October 26, 2026 07:41
ca42022 to
fc10027
Compare
bitsandfoxes
force-pushed
the
test/playmode-event-timeout
branch
from
October 26, 2026 08:15
96055df to
0a63f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playmode integration tests now give an event 5 s to reach the test HTTP handler instead of 1 s, so a slow CI runner no longer fails them.
Job 119764822362 failed
BugFarmScene_MultipleSentryInit_SendEventForTheLatestwithExpected: not equal to <string.Empty>. The handler loggedtimed out waiting for an eventat 57.505 andreturns event17 ms later, at 57.522. The other 372 tests passed, and the next run on the branch was green.GetEventreturns as soon as the event shows up, so a passing test isn't any slower. Only a test that's failing anyway waits the full 5 s. The exception is the sanity check in that same test, which expects the first handler to receive nothing. It would always wait out the full timeout, so it keeps its 1 s.Stacked on #2905.
CI evidence: the playmode tests passed in the Build Unity SDK job of run 40228677752, on #2908 directly above this. This PR's own run was cancelled when the Linux native SDK build broke on the .NET 9 install (#2907).
Rebased onto #2907: run 40291024676 is green on the first attempt, playmode tests included.
🤖 Generated with Claude Code