Skip to content

fix(forms): Include :orgId in new provider form route for search - #121051

Merged
TkDodo merged 4 commits into
masterfrom
seer/fix/settings-new-provider-route
Sep 4, 2026
Merged

fix(forms): Include :orgId in new provider form route for search#121051
TkDodo merged 4 commits into
masterfrom
seer/fix/settings-new-provider-route

Conversation

@sentry

@sentry sentry Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This PR fixes an issue where navigating to the "New Provider" form via Settings Search resulted in a "Route not found" error.

The root cause was that the <FormSearch> component in static/app/views/settings/featureFlags/changeTracking/newProviderForm.tsx defined its route prop as /settings/feature-flags/change-tracking/new-provider/, omitting the required :orgId segment.

This incomplete route was then picked up by the Settings Search index (generatedFieldRegistry.ts), leading to an invalid URL being generated for the search result.

The fix involves:

  1. Updating the route prop in newProviderForm.tsx to /settings/:orgId/feature-flags/change-tracking/new-provider/.
  2. Regenerating and committing the generatedFieldRegistry.ts file to reflect this change.

This ensures that the Settings Search correctly registers and generates valid URLs for the "New Provider" form.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes JAVASCRIPT-3B75

Comment @sentry <feedback> on this PR to have Autofix iterate on the changes.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 3, 2026
@sentry sentry Bot changed the title fix(settings): Correct FormSearch route for new feature flag provider fix(forms): Include :orgId in new provider form route for search Aug 3, 2026
@TkDodo TkDodo added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Aug 13, 2026
@TkDodo
TkDodo marked this pull request as ready for review August 13, 2026 13:54
@TkDodo
TkDodo requested a review from a team as a code owner August 13, 2026 13:54
@getsantry getsantry Bot added the Stale label Sep 4, 2026
@getsantry

getsantry Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

…ew-provider-route

Co-Authored-By: Dominik Dorfmeister <dominik.dorfmeister@sentry.io>
@github-actions github-actions Bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Sep 4, 2026
@TkDodo TkDodo added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Sep 4, 2026
@TkDodo
TkDodo enabled auto-merge (squash) September 4, 2026 16:24
@TkDodo
TkDodo merged commit 068baa3 into master Sep 4, 2026
87 of 88 checks passed
@TkDodo
TkDodo deleted the seer/fix/settings-new-provider-route branch September 4, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Stale Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant