ref(ui): Drop unused optional args in explore - #123227
Open
JonasBa wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
the
Scope: Frontend
3 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ...data, | ||
| name: newTitle, | ||
| starred, | ||
| starred: true, |
Contributor
There was a problem hiding this comment.
Starred toggle ignored when saving
Medium Severity
saveQuery is passed to openSaveQueryModal, which calls it with the user's Starred toggle. Dropping that argument and hardcoding starred: true means unchecking Starred still saves the query as starred in multi-query and metrics save flows.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 9f0fcc0. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
Restores the list the hook used before the unused-args cleanup so knip sees the export. Co-authored-by: Cursor <cursoragent@cursor.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8908fcf. Configure here.
The unused-args cleanup dropped parameters that callers still pass: saveQuery must honor the modal Starred toggle, and useAllMobileProj() must use the broader mobile list unless replayPlatforms is set. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #122373 and #122624 so this folder can be reviewed on its own (~190 LOC).
Summary
static/app/views/explore.Files
static/app/views/explore/conversations/components/conversationSummary.tsxstatic/app/views/explore/conversations/utils/urlParams.tsxstatic/app/views/explore/hooks/useSaveMultiQuery.tsxstatic/app/views/explore/hooks/useTraceItemAttributes.tsxstatic/app/views/explore/hooks/useTraceItemDetails.tsxstatic/app/views/explore/hooks/useTraces.spec.tsxstatic/app/views/explore/hooks/useTraces.tsxstatic/app/views/explore/logs/useLogsQuery.tsxstatic/app/views/explore/logs/useValidateLogsTab.tsxstatic/app/views/explore/metrics/hooks/metricBoundsApiOptions.tsxstatic/app/views/explore/metrics/hooks/metricHeatMapApiOptions.tsxstatic/app/views/explore/metrics/hooks/useSaveMetricsMultiQuery.tsxstatic/app/views/explore/metrics/metricsQueryParams.tsxstatic/app/views/explore/queryParams/visualize.tsstatic/app/views/explore/releases/detail/utils.tsxstatic/app/views/explore/releases/list/releaseCard/releaseCardProjectRow.tsxstatic/app/views/explore/releases/releaseBubbles/useReleaseBubbles.tsxstatic/app/views/explore/releases/utils/index.tsxstatic/app/views/explore/replays/detail/playlist/index.tsxstatic/app/views/explore/replays/detail/useAllMobileProj.tsxstatic/app/views/explore/replays/list.tsxstatic/app/views/explore/replays/list/replayIndexTable.tsxstatic/app/views/explore/replays/list/replayOnboardingPanel.tsxstatic/app/views/explore/tables/tracesTable/fieldRenderers.tsxstatic/app/views/explore/tables/tracesTable/utils.tsxstatic/app/views/explore/utils/validateEventParamsOptions.tsxTest plan
static/app/views/explore.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.