feat(settings): clarify Spike Protection notification setup - #123517
Open
sentry-junior[bot] wants to merge 5 commits into
Open
feat(settings): clarify Spike Protection notification setup#123517sentry-junior[bot] wants to merge 5 commits into
sentry-junior[bot] wants to merge 5 commits into
Conversation
Co-Authored-By: Shannon Anahata <shannon.anahata@sentry.io>
github-actions
Bot
added
the
Scope: Frontend
sfanahata
reviewed
Sep 3, 2026
Co-Authored-By: Shannon Anahata <shannon.anahata@sentry.io>
sfanahata
marked this pull request as ready for review
September 3, 2026 22:12
Contributor
|
I checked the preview. This looks much better to me! |
TkDodo
reviewed
Sep 4, 2026
TkDodo
approved these changes
Sep 4, 2026
TkDodo
left a comment
TkDodo
left a comment
Collaborator
There was a problem hiding this comment.
generally okay but please delete the unnecessary test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the distinction between enabling Spike Protection and configuring notifications.
Test plan
pnpm test-ci static/gsApp/views/spikeProtection/spikeProtectionProjects.spec.tsx static/app/views/settings/account/notifications/notificationSettingsByType.spec.tsx(24 passed)NODE_OPTIONS=--max-old-space-size=6144 pnpm run lint:js static/gsApp/views/spikeProtection/index.tsx static/gsApp/views/spikeProtection/spikeProtectionProjects.tsx static/gsApp/views/spikeProtection/spikeProtectionProjects.spec.tsx static/app/views/settings/account/notifications/fields.tsx static/app/views/settings/account/notifications/notificationSettingsByType.tsx static/app/views/settings/account/notifications/notificationSettingsByType.spec.tsxNODE_OPTIONS=--max-old-space-size=6144 .venv/bin/prek run -qgit diff --checkRequested by shannon.anahata.
--
View Junior Session [Sentry]