fix(autofix): Propagate the referrer through the RCA feature path - #123574
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
chromy
force-pushed
the
chromy/2026-09-03-fix-rca-feature-referrer
branch
from
September 3, 2026 14:13
a4e5a9a to
77e4c3d
Compare
chromy
marked this pull request as ready for review
September 3, 2026 14:23
chromy
force-pushed
the
chromy/2026-09-03-fix-rca-feature-referrer
branch
2 times, most recently
from
September 3, 2026 14:38
a12e6b8 to
f7c3aee
Compare
chromy
force-pushed
the
chromy/2026-09-03-fix-rca-feature-referrer
branch
3 times, most recently
from
September 3, 2026 17:28
a08f72a to
097741c
Compare
rbro112
approved these changes
Sep 3, 2026
rbro112
reviewed
Sep 3, 2026
| ) | ||
| case SeerRunType.FEATURE_RUN: | ||
| wire_body = {**body, "ref": str(run.uuid)} | ||
| wire_body = {**body, "ref": str(run.uuid), "referrer": run.referrer or "unknown"} |
Member
There was a problem hiding this comment.
Maybe it would be best for us to put the referrer in the body and that way we wouldn't need any special handling here?
Contributor
Author
There was a problem hiding this comment.
yeah sounds good, I've tweaked it a bit so we don't need a change here
chromy
force-pushed
the
chromy/2026-09-03-fix-rca-feature-referrer
branch
from
September 4, 2026 14:05
097741c to
066a73c
Compare
The autofix RCA feature run carried no referrer. Seer stamped only `step` on the query metadata that `AutofixOnCompletionHook` reads the trigger source from, because nothing on the feature-run wire carried one. With `group_id` present in the run metadata the hook also skipped the run-mirror lookup that holds the referrer, and fell back to `ON_COMPLETION_HOOK` — for the step webhook, the fixability introspection, and every pipeline step after root cause, which cost night shift runs their `enable_bash_tools`. Declare `referrer` on `SeerFeatureRunRequest` so it rides the feature-run wire, and have `start_feature_run` put it there. Callers own the value: it is a required argument now, sent on the body for Seer and passed to `enqueue_seer_run` for the `SeerRun` mirror as before, so neither `enqueue_seer_run` nor the outbox handler changes. Smart assignment supplies its feature id. Feature-run outbox rows enqueued before this deploy carry no referrer and dispatch without the field; nothing substitutes a fallback. Resolve the run mirror unconditionally too, the way `stopping_point` already does, so in-flight runs still recover the referrer. Agent transcript: https://claudescope.sentry.dev/share/J-PVJPZQLvJ1unYmBQocDe0B7quXaRmGhtf_3qzswjg
chromy
force-pushed
the
chromy/2026-09-03-fix-rca-feature-referrer
branch
from
September 4, 2026 14:14
066a73c to
d03bf65
Compare
chromy
enabled auto-merge (squash)
September 4, 2026 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.