Repository navigation
chore(deps): Bump sentry-scm to 2.0.0 - #128747
Merged
Merged
Conversation
sentry-scm 2.0 takes RPC signing secrets as scm.Secret so they show as [Filtered] in error reports: the SDK scrubs a variable named `secret` but not `secrets` or values inside a list, so a failure while verifying a request could send every SCM_RPC_SHARED_SECRET to Sentry. RpcServer now refuses plain strings, so wrap each configured secret when building it. The test session adapter also accepts the `stream` argument the RPC client has passed to Session.post since 1.10.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
giovanni-guidini
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sentry-scm 2.0.0 (getsentry/scm-platform#162) takes RPC signing secrets as
scm.Secret, which shows as[Filtered]in error reports. The SDK scrubs a local namedsecret, but notsecretsand not values inside a list. So a failure while verifying a request could send everySCM_RPC_SHARED_SECRETto Sentry.RpcServernow refuses plain strings, so this bump is required before Sentry can pick up 2.0.Approach
make_serverwraps each configured secret inSecretwhen building theRpcServer. TheSCM_RPC_SHARED_SECRETsetting stays alist[str], so deploy config doesn't change.test_scm_rpc.pypassesSecrettomake_proxy_client,sign_getandsign_post.DjangoTestClientSessionAdapter.postacceptsstream, which the RPC client has passed toSession.postsince 1.10.0. Sentry was still on 1.9.0, so this hadn't come up before.The signature on the wire is the same, so this can deploy independently of the matching Seer change (getsentry/seer#9056).
Testing
pytest tests/sentry/scmplus every other test module that importsscmpasses (767 tests). mypy and prek are clean on the changed files.🤖 Generated with Claude Code