Repository navigation
strict yaml unmarshal loading test files - #93
Merged
Merged
Conversation
Signed-off-by: Fernando Cainelli <fernando.cainelli@getyourguide.com>
Signed-off-by: Fernando Cainelli <fernando.cainelli@getyourguide.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
clue-gyg
approved these changes
Nov 16, 2026
clue-gyg
left a comment
There was a problem hiding this comment.
✅ Auto-approved
The change is test-only and about 30 lines in total, which is under the 50-line limit. It switches yaml.Unmarshal to UnmarshalStrict in test/testcases.go, adds one test in test/testcases_test.go, and adds one testdata fixture. It touches no production code, dependencies, or security-sensitive files.
zeusdeux
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
YAML unmarshaling was not validating unknown fields in test configuration files, allowing malformed test data to silently pass through and causing confusing test failures downstream.
Solution
yaml.Unmarshaltoyaml.UnmarshalStrictto reject unknown fields during test loading