Skip to content

Add Serbian, Slovenian, and Ukrainian content languages - #134

Closed
lrcarrera wants to merge 1 commit into
mainfrom
add-exported-content-languages
Closed

lrcarrera wants to merge 1 commit into
mainfrom
add-exported-content-languages

Conversation

@lrcarrera

@lrcarrera lrcarrera commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds sl (Slovenian), sr (Serbian), and uk (Ukrainian) to the published CntLanguage enum.

…ges.

Search indexes sr, sl, and uk, but the partner CntLanguage enum did not list them.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central TS config (base), Organization UI (inherited); Enforced overrides: Organization
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1d2f447e-43dc-4a64-9eb0-1683d6be6a89
Commits

Reviewing files that changed from the base of the PR and between 12c9da4 and 8b8eba5.

Files selected for processing: 1
  • spec/components/commons/fields.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Additional comments: 1
spec/components/commons/fields.yaml: 1

115-116: 🗄️ Data Integrity & Integration

No gateway incompatibility is established.

The schema addition is used by both query parameters and booking/cart payloads, but the repository contains no public-partner-api validator or compatibility contract. The reported gateway rejection remains an unverified PR-context claim, so this does not support a major issue.

📝 Summary

Risk Score: High - Human review needed

The CntLanguage enum adds sl (Slovenian), sr (Serbian), and uk (Ukrainian). This updates the published API specification so partners can identify these content languages.

The gateway’s acceptance of these codes remains unconfirmed. Verify that public-partner-api accepts all three codes before merging.

The CntLanguage enum adds the sl, sr, and uk language codes. Existing values remain in the enum.

Suggested labels: coderabbit-risk:high

Priority: Not assessed

Change: Feature

Merge Risk: Low · up to 8b8eb

The spec will list three content languages that the author reports the partner gateway does not yet accept. Merge only after the gateway change has shipped, as the PR description already requires.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lrcarrera

Copy link
Copy Markdown
Contributor Author

Closing this draft. The published CntLanguage enum on main already matches public-partner-api. This branch added sl, sr, and uk from search indexing, which the downstream spec and Languages.java do not accept.

@lrcarrera lrcarrera closed this Oct 28, 2026
@lrcarrera
lrcarrera deleted the add-exported-content-languages branch October 28, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant