Skip to content

NO-TICKET: Fix itinerary transportation_type documented values - #135

Merged
kingaM merged 2 commits into
mainfrom
no-ticket/itinerary-transportation-type-doc
Nov 5, 2026
Merged

kingaM merged 2 commits into
mainfrom
no-ticket/itinerary-transportation-type-doc

Conversation

@kingaM

@kingaM kingaM commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

The documented list (bus, boat, plane, walking, …) never occurs. The field has the same type as the option-level transportation mode, and all 57 values in the 2026-11-04 export are in that list (e.g. speed_boat, golf_cart, dhow). Nothing validates against the list, so the doc says so. Raised by Trip.com.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central TS config (base), Organization UI (inherited); Enforced overrides: Organization
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5898a452-33dd-468a-ba9f-28a655df908b
Commits

Reviewing files that changed from the base of the PR and between c8a37b0 and 00c7fbc.

Files selected for processing: 1

  • spec/components/schema/itinerary.yaml

No actionable comments were generated in the recent review.

Summary

Risk Score: Normal - Addressing the comments needed

The itinerary schema now documents that transportation_type uses the same values as TransportationType.mode. It updates the example to bus_coach and advises clients to handle unknown values as generic transfers.

This specification change aligns the documented API values with the reported data. Clients that assume a fixed set of transport values may need to handle additional values.

The itinerary schema now describes how transportation_type relates to TransportationType.mode. It adds example values and states that unknown values should be treated as generic transfers. The example changes to bus_coach.

Change: Other

Merge Risk: Minimal · previous review c8a37

The update clarifies transportation values and unknown-value handling without changing runtime behavior. No merge-blocking issue is identified.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central TS config (base), Organization UI (inherited); Enforced overrides: Organization
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb9e942c-fef0-40bf-a5dd-cba49fca5f20
Commits

Reviewing files that changed from the base of the PR and between 12c9da4 and c8a37b0.

Files selected for processing: 1

  • spec/components/schema/itinerary.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kingaM
kingaM marked this pull request as ready for review November 5, 2026 14:47
@kingaM
kingaM requested a review from a team as a code owner November 5, 2026 14:47
@clue-gyg clue-gyg removed the risk:low label Nov 5, 2026
@gyg-pr-tool
gyg-pr-tool Bot requested a review from arihantgupta-28 November 5, 2026 14:47

@clue-gyg clue-gyg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved

The change is documentation-only, 4 lines in spec/components/schema/itinerary.yaml. It updates one field's description text and its example value (bus → bus_coach). The type, nullability and validation are unchanged, so the API contract is not altered.

@kingaM
kingaM merged commit 6eb7761 into main Nov 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants