Repository navigation
Release locationallocation 0.2.1 (CRAN resubmission) - #16
Merged
Merged
Conversation
CRAN's incoming checks of 0.2.0 flagged the allocation() example at 10.3 s (Debian) and 11.3 s (Windows). - mask_raster_to_polygon() rasterizes the polygon once (touches = TRUE, as terra::mask() does) instead of masking with terra; raster masks are compared by cell values. - allocation_setup() and weighted_demand() work on cell values; demand weights are only resampled when their grid differs from the demand. - Import gdistance, igraph, raster, sf, terra and ggplot2 in the NAMESPACE, so they load with the package rather than inside the first example. - Results are identical to 0.2.0 on the Naples data (travel times, coverage, masked rasters, selected facilities). The slowest example now takes 1.5 s with R CMD check --as-cran --timings. - Bump to 0.2.1; NEWS, cran-comments (resubmission notes, including the spelling false positives), CITATION.cff and codemeta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRAN's automatic incoming checks rejected 0.2.0 because the
allocation()example took 10.3 s on Debian and 11.3 s on Windows. They also flagged some words in DESCRIPTION as possible misspellings, but these are false positives (author names, "et al.", "geospatial").Changes:
mask_raster_to_polygon()rasterizes the polygon withtouches = TRUE, the same rule asterra::mask(). A test checks that the result equalsterra::mask().gdistance,igraph,raster,sf,terraandggplot2are imported in the NAMESPACE, so they load with the package instead of during the first example.R CMD check --as-cran --timingsgives 0 errors and 0 warnings; the 2 NOTEs are local only (no pandoc or V8). The slowest example now takes 1.5 s (about 8 s before).