Skip to content

feat: promote webhooks to primary with IMAP fallback - #234

Open
giscebot wants to merge 1 commit into
feat/webhooks-canary-ingestfrom
feat/webhooks-primary-fallback
Open

giscebot wants to merge 1 commit into
feat/webhooks-canary-ingestfrom
feat/webhooks-primary-fallback

Conversation

@giscebot

@giscebot giscebot commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add explicit primary webhook mode after the canary gate
  • require a second operator acknowledgement (GITHUB_AGENT_BRIDGE_WEBHOOK_PRIMARY_ACK=true) to prevent accidental promotion
  • keep the same policy trust/action/routing decisions
  • preserve IMAP as an active idempotent safety net and document configuration-only rollback
  • include workflow conclusions in normalized input so failed runs retain their actionable classification

Safety and rollback

Primary mode fails closed without both a policy path and the explicit acknowledgement. Rolling back requires only returning webhook mode to shadow; the IMAP reader remains supported and must not be marked seen merely because webhooks are primary.

No arbitrary IMAP delay is introduced: delaying the reader would also delay genuine webhook gaps and complicate durable UID handling. Correctness remains independent of arrival order through the canonical event constraint.

Dependency

Stacked on #233. Enable only after #232 reports no unexplained IMAP-only actionable events for the agreed observation window.

Validation

  • pytest -q — 392 passed
  • dashboard npm test -- --run — 60 passed
  • dashboard npm run build — passed

Requested by: @ecarreras

Refs #191

TASK-85718

@giscebot
giscebot added this pull request to stack #235 October 3, 2026 10:22
@giscebot
giscebot requested a review from ecarreras October 3, 2026 10:23
@giscebot giscebot self-assigned this Oct 3, 2026
@giscebot
giscebot force-pushed the feat/webhooks-primary-fallback branch from 2a89007 to 4710941 Compare October 3, 2026 13:40
@giscebot
giscebot force-pushed the feat/webhooks-primary-fallback branch from 4710941 to d3b202a Compare October 3, 2026 13:54
Co-authored-by: Eduard Carreras <ecarreras@gisce.net>
@ecarreras
ecarreras force-pushed the feat/webhooks-primary-fallback branch from d3b202a to cd0b895 Compare October 3, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant