Conversation
giscebot
added this pull request to stack #235
October 3, 2026 10:22
giscebot
force-pushed
the
feat/webhooks-primary-fallback
branch
from
October 3, 2026 13:40
2a89007 to
4710941
Compare
giscebot
force-pushed
the
feat/webhooks-primary-fallback
branch
from
October 3, 2026 13:54
4710941 to
d3b202a
Compare
Co-authored-by: Eduard Carreras <ecarreras@gisce.net>
ecarreras
force-pushed
the
feat/webhooks-primary-fallback
branch
from
October 3, 2026 13:58
d3b202a to
cd0b895
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
primarywebhook mode after the canary gateGITHUB_AGENT_BRIDGE_WEBHOOK_PRIMARY_ACK=true) to prevent accidental promotionSafety and rollback
Primary mode fails closed without both a policy path and the explicit acknowledgement. Rolling back requires only returning webhook mode to
shadow; the IMAP reader remains supported and must not be marked seen merely because webhooks are primary.No arbitrary IMAP delay is introduced: delaying the reader would also delay genuine webhook gaps and complicate durable UID handling. Correctness remains independent of arrival order through the canonical event constraint.
Dependency
Stacked on #233. Enable only after #232 reports no unexplained IMAP-only actionable events for the agreed observation window.
Validation
pytest -q— 392 passednpm test -- --run— 60 passednpm run build— passedRequested by: @ecarreras
Refs #191
TASK-85718