feat: add webhook delivery detail - #237
Conversation
Persist verified webhook payloads for the configured retention window and expose an admin-only delivery detail with linked job status. Add shareable dashboard navigation for inspecting the payload and opening the generated job.\n\nRefs #191\n\nCo-authored-by: Eduard Carreras <ecarreras@gisce.net>
6d3429c to
fdd456e
Compare
bc2f6c0 to
d3cff79
Compare
d3cff79 to
fdd456e
Compare
|
@giscebot resol conflictes |
Resolve webhook delivery detail conflicts while preserving ingestion status and linked-job data. Co-authored-by: ecarreras <294235+ecarreras@users.noreply.github.com>
|
Conflictes resolts al commit 09c0c3e, integrant origin/main sense reescriure la branca. La resolució conserva el payload/detall de delivery i incorpora els nous camps enqueue_status/job_id; també corregeix la consulta del detall perquè retorni el job enllaçat o coalescit. He regenerat els assets del dashboard. Validació local: 417 tests Python i 64 tests del dashboard; build del dashboard correcte. Els tres checks de CI del commit estan verds i GitHub marca la PR com a mergeable. |
pilipilisbot
left a comment
There was a problem hiding this comment.
Reviewed the webhook delivery detail changes end to end: schema/backfill path, payload retention, admin-only API detail endpoint, linked/coalesced job lookup, dashboard routing/detail view, docs, and the conflict-resolution commit.
I did not find blocking issues. The implementation keeps the detail endpoint behind dashboard admin auth, preserves legacy rows with payload: null, and the schema migration covers existing webhook_shadow_receipts tables.
Validation checked:
- python3 -m compileall -q src tests
- git diff --check
- GitHub checks are green: dashboard, pytest 3.11, pytest 3.12
Local pytest/Vitest execution was not available in this worktree because the local environment does not have pytest/vitest installed, so I relied on the passing CI for the full test suites.
|
Troballa operativa post-merge: l’esdeveniment de merge No he fet cap canvi de branca ni metadata (revisió només). La PR ja estava aprovada, els tres checks eren verds i el merge és |
Summary
Validation
pytest -q— 417 passednpm test— 64 passednpm run buildRefs #191
Requested by: @ecarreras