Skip to content

feat: add webhook delivery detail - #237

Merged
ecarreras merged 2 commits into
mainfrom
feat/webhook-delivery-detail
Oct 5, 2026
Merged

ecarreras merged 2 commits into
mainfrom
feat/webhook-delivery-detail

Conversation

@giscebot

@giscebot giscebot commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • retain each verified webhook JSON payload for the configured receipt retention window
  • add an admin-only delivery detail endpoint with payload hash and linked/coalesced job status
  • add shareable delivery detail UI with navigation to the hook and generated job
  • document retention and legacy deliveries without stored payloads

Validation

  • pytest -q — 417 passed
  • npm test — 64 passed
  • npm run build

Refs #191

Requested by: @ecarreras

@giscebot
giscebot added this pull request to stack #235 October 5, 2026 08:04
@giscebot
giscebot requested a review from ecarreras October 5, 2026 08:05
@giscebot giscebot self-assigned this Oct 5, 2026
Persist verified webhook payloads for the configured retention window and expose an admin-only delivery detail with linked job status. Add shareable dashboard navigation for inspecting the payload and opening the generated job.\n\nRefs #191\n\nCo-authored-by: Eduard Carreras <ecarreras@gisce.net>
@giscebot
giscebot force-pushed the feat/webhook-delivery-detail branch from 6d3429c to fdd456e Compare October 5, 2026 08:52
@ecarreras
ecarreras force-pushed the feat/webhook-delivery-detail branch 2 times, most recently from bc2f6c0 to d3cff79 Compare October 5, 2026 09:16
@giscebot
giscebot force-pushed the feat/webhook-delivery-detail branch from d3cff79 to fdd456e Compare October 5, 2026 09:42
Base automatically changed from feat/webhooks-primary-fallback to main October 5, 2026 15:54
@ecarreras

Copy link
Copy Markdown
Member

@giscebot resol conflictes

Resolve webhook delivery detail conflicts while preserving ingestion status and linked-job data.

Co-authored-by: ecarreras <294235+ecarreras@users.noreply.github.com>
@giscebot

giscebot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

Conflictes resolts al commit 09c0c3e, integrant origin/main sense reescriure la branca.

La resolució conserva el payload/detall de delivery i incorpora els nous camps enqueue_status/job_id; també corregeix la consulta del detall perquè retorni el job enllaçat o coalescit. He regenerat els assets del dashboard.

Validació local: 417 tests Python i 64 tests del dashboard; build del dashboard correcte. Els tres checks de CI del commit estan verds i GitHub marca la PR com a mergeable.

@ecarreras
ecarreras requested a review from pilipilisbot October 5, 2026 17:00

@pilipilisbot pilipilisbot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the webhook delivery detail changes end to end: schema/backfill path, payload retention, admin-only API detail endpoint, linked/coalesced job lookup, dashboard routing/detail view, docs, and the conflict-resolution commit.

I did not find blocking issues. The implementation keeps the detail endpoint behind dashboard admin auth, preserves legacy rows with payload: null, and the schema migration covers existing webhook_shadow_receipts tables.

Validation checked:

  • python3 -m compileall -q src tests
  • git diff --check
  • GitHub checks are green: dashboard, pytest 3.11, pytest 3.12

Local pytest/Vitest execution was not available in this worktree because the local environment does not have pytest/vitest installed, so I relied on the passing CI for the full test suites.

@ecarreras
ecarreras merged commit 758e81f into main Oct 5, 2026
3 checks passed
@ecarreras
ecarreras deleted the feat/webhook-delivery-detail branch October 5, 2026 17:18
@giscebot

giscebot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

Troballa operativa post-merge: l’esdeveniment de merge event-32530539283 s’ha despatxat com reply_comment / review_only, tot i que reproduint el mateix merge amb el parser actual retorna sync_after_merge. Això apunta a un desajust en la normalització o el transport de l’esdeveniment, no al diff de detall de deliveries d’aquesta PR.

No he fet cap canvi de branca ni metadata (revisió només). La PR ja estava aprovada, els tres checks eren verds i el merge és 758e81f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants