Repository navigation
deps(crypto): upgrade argon2 to 0.6 without breaking stored password hashes - #330
Merged
Merged
Conversation
Port hash_password to the 0.6 API (hash_password_with_salt, phc::PasswordHash) and pin with a test that a hash made by argon2 0.5.3 still verifies, so password rows stored by earlier sc-forge builds keep working. Supersedes #323.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tonibergholm
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's argon2 0.6 bump (#323) fails to compile: 0.6 removed
SaltStringand changedhash_passwordto take only the password. This portsscl-crypto's password hashing to the new API, and the hashes it writes don't change.hash_passwordnow callshash_password_with_saltwith the same 16 random bytes fromOsRng. The output is still a$argon2id$v=19$m=19456,t=2,p=1$...PHC string, because the default parameters are the same in 0.6.Supersedes #323.
Proof: the 0.5.3 fixture verifies under 0.6, and fmt, clippy (
-D warnings) and thescl-cryptoandscl-forgetests pass locally.Reviewed with sol-loop: 1 round with gpt-6.1-sol on high. Sol verdict: approved
Created with Claude Opus 5.5 in T3 Code (Claude Code harness).