Repository navigation
test(forge): prove --git-memory-limit stops an oversized push on Linux - #333
Merged
Merged
Conversation
A server started with a 64 MiB RLIMIT_DATA refuses a push of a 128 MiB blob (git inflates it in memory to hash it) with git's out-of-memory error and no ref change; the same push lands under the default limit. Linux only, since macOS does not enforce RLIMIT_DATA.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonibergholm
approved these changes
Nov 9, 2026
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--git-memory-limitsetsRLIMIT_DATAon each git child, but nothing had shown it working at runtime; #316 tracked that gap. This adds a Linux-only test.Out of memory, malloc failedand moves no ref. The test asserts that message.docs/THREAT-MODEL.mdcites the test. It also says macOS doesn't enforce the limit, and that a cgroup on the service is the host-wide bound on Linux.Proof: 3 of 3 runs pass in a
rust:1.96.1Linux container (git 2.47.3), and the limited push printedremote: fatal: Out of memory, malloc failed (tried to allocate 134217729 bytes). fmt and clippy pass. CI's ubuntu job runs the test.Reviewed with sol-loop: 1 round with gpt-6.1-sol on high. Sol verdict: approved
Created with Claude Opus 5.5 in T3 Code (Claude Code harness).