Repository navigation
Populate funding links and maintainers in direct-registry lookups - #84
Merged
andrew merged 1 commit intoOct 20, 2026
Merged
Conversation
andrew
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83
Problem
PackageInfo.FundingLinksandPackageInfo.Maintainerswere only filled in by the ecosyste.ms backend. WithNewRegistriesClient(), or for packages the hybrid client sends to a direct registry, both fields came back empty. Consumers building funding reports had to parse registry-specific metadata themselves or stick to one backend.git-pkgs/registries#110 (closing git-pkgs/registries#34) added normalized
FundingLinksandMaintainersfields toregistries.Package, so the data is now available to copy across.Change
RegistriesClient.BulkLookupcopiespkg.FundingLinksintoPackageInfo.FundingLinks.RegistriesClient.BulkLookupmapspkg.MaintainersintoPackageInfo.Maintainersusing a newmaintainersFromRegistryhelper. Login, Name, Email, URL and Role are copied, and registries' internalUUIDis dropped. Empty input returns nil, matching how the ecosyste.ms backend'sconvertMaintainersbehaves.PackageInfothrough whole, so packages it routes to a registry get both fields without further changes.PackageInfofield comment, which said these fields were ecosyste.ms only.What each registry provides, per git-pkgs/registries#110:
FundingLinksMaintainersfundingfieldmaintainersownersfunding_uriproject_urlsOther registries leave both fields nil, as before.
Dependency note
github.com/git-pkgs/registriesis bumped fromv0.9.3to the #110 merge commit (v0.10.1-0.20261019065955-4d31fcfe8bf0), because no tagged release includes it yet (the latest tag isv0.10.0). Once registries cuts the next release, this can be switched to the tag, here or in a follow-up dependabot bump.github.com/git-pkgs/pommoves from v0.1.7 to v0.1.8 as an indirect dependency, because the newer registries requires it.Tests
TestRegistriesClientBulkLookupCopiesFundingAndMaintainersruns oneBulkLookupagainst a mock registry server with:url) plus a maintainer;funding_uri.TestMaintainersFromRegistrycovers nil and empty input plus the full field mapping.go build ./...,go vet ./...,go test -race ./...andgolangci-lint run ./...pass, andgo mod tidyleaves no diff.