Skip to content

Use shared sbom parser for mirror sources - #510

Merged
andrew merged 3 commits into
mainfrom
use-shared-sbom
Oct 20, 2026
Merged

andrew merged 3 commits into
mainfrom
use-shared-sbom

Conversation

@andrew

@andrew andrew commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Use git-pkgs/sbom.Parse for mirroring CycloneDX JSON/XML and SPDX JSON/tag-value documents. Preserve every package PURL, scoped package identities, and container image options while removing the separate CycloneDX and SPDX parser dependencies.

Uses sbom v0.1.7, which includes git-pkgs/sbom#18.

@andrew
andrew marked this pull request as ready for review October 19, 2026 07:20
Copilot AI balanced review requested due to automatic review settings October 19, 2026 07:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@simonchrz simonchrz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. One behaviour change worth knowing about: nested CycloneDX components are now mirrored too, where before only top-level ones were. metadata.component still isn't, which matters now that #502 fails the run on a mirror error. This needs a rebase after #516 for go.mod/go.sum. I resolved it locally with go get github.com/git-pkgs/sbom@v0.1.7 && go mod tidy and the mirror tests pass.

@andrew
andrew merged commit 5dfd01e into main Oct 20, 2026
10 checks passed
@andrew
andrew deleted the use-shared-sbom branch October 20, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants