Repository navigation
Populate Packagist version artifacts from dist - #104
Merged
Merged
Conversation
fetch.Resolver reads Artifacts, but Packagist only stored the dist URL in Metadata, so resolving a Composer package returned no download URL. Claude-Session: https://claude.ai/code/session_01NxsA75HBjdWQKcdx7FDTDc
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Packagist client stored each version's dist URL only as
Metadata["dist_url"].fetch.ResolverreadsArtifacts, ordownload_url/tarballin metadata, so registering the Packagist registry and resolving any Composer package returnedno download URL available.FetchVersionsnow sets oneArtifactper version fromdist.url, with the dist shasum as integrity. The filename is the last path segment of the URL, with.zipadded for zip dists that have no extension (GitHub zipball URLs end in a bare commit hash). That matches the filename git-pkgs/proxy's Composer handler serves archives under.Metadatais unchanged.The URL still goes through the resolver's unsafe-URL check in
selectArtifact.https://claude.ai/code/session_01NxsA75HBjdWQKcdx7FDTDc