Repository navigation
Select artifacts by PURL qualifiers, and fix the conda client - #105
Merged
Merged
Conversation
owner is an object and upload_time a string in the real API, so FetchVersions failed on every package. Each file is now an Artifact with its subdir, build and arch. Claude-Session: https://claude.ai/code/session_01NxsA75HBjdWQKcdx7FDTDc
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95
ResolveOptionsgainsQualifiers map[string]string. When a version lists several artifacts,arch,distro,subdirandbuildare matched against artifact metadata of the same name, andErrNoMatchingArtifactis returned when none match. An artifact that doesn't record a qualifier isn't ruled out by it, so ecosystems whose clients don't publish that metadata keep resolving as before.repository_urlandchannelchoose the registry rather than the file, so the resolver ignores them and the caller registers a registry for that URL. Qualifiers don't affect ecosystems resolved throughURLs().Download, where name and version already determine the file.Conda had no artifacts to select from, and its client couldn't decode the real API at all: anaconda.org returns
owneras an object andupload_timeas a string like2024-09-17 07:32:19.214000+00:00, while the client expected a string and a Unix timestamp. EveryFetchVersions,FetchPackageandFetchMaintainerscall failed with a JSON error, and the tests didn't notice because their fixtures were built from the same structs. The client now decodes the real shape, and each file becomes anArtifactwith itssubdir,build,archandplatform, with the scheme-relativedownload_urlgivenhttps:. The new conda test uses a response trimmed fromapi.anaconda.org.Against the live API, resolving
conda-forge/zlib1.3.1 withsubdirset tolinux-64,osx-arm64andwin-64returns the matching build for each, and the osx-arm64 download matches its published sha256.When a client starts recording one of these qualifiers, a request with a non-matching value that used to resolve to some artifact will return
ErrNoMatchingArtifactinstead.https://claude.ai/code/session_01NxsA75HBjdWQKcdx7FDTDc