Skip to content

Add implementation brainstorming agent + skill#2129

Open
starlightretailceo wants to merge 2 commits into
github:mainfrom
starlightretailceo:contrib/implementation-brainstormer
Open

Add implementation brainstorming agent + skill#2129
starlightretailceo wants to merge 2 commits into
github:mainfrom
starlightretailceo:contrib/implementation-brainstormer

Conversation

@starlightretailceo

Copy link
Copy Markdown
Contributor

Summary

  • Agent (implementation-brainstormer.agent.md): Turns rough feature ideas, bug fixes, or product requests into multiple implementation options, scored tradeoffs, and a first testable slice.
  • Skill (skills/implementation-brainstorming/SKILL.md): Reusable brainstorming framework with option-generation prompts, scoring rubric, risk prompts, recommendation template, and first-slice checklist.

Motivation

This replaces the closed format-migrator idea from #2072 with a more generally useful brainstorming implementation. Instead of duplicating platform migration behavior Copilot already handles, it helps users move from vague intent to practical, ranked implementation paths and a reviewable first PR-sized slice.

Test plan

  • Ran npm run build to regenerate README indexes.
  • Confirmed the new implementation-brainstorming skill validates in npm run skill:validate output.
  • Use the agent on a real feature idea and verify it produces ranked options plus a first testable slice.

Note: full local npm run skill:validate currently reports an unrelated pre-existing aws-cloudwatch-investigation name issue on current main; the new skill itself validates successfully.

Add a practical brainstorming workflow that generates implementation options, scores tradeoffs, and produces a first testable slice.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added agent PR touches agents new-submission PR adds at least one new contribution skills PR touches skills targets-main PR targets main instead of staged labels Jun 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Skill Validator Results

✅ All checks passed

Scope Checked
Skills 1
Agents 1
Total 2
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ Found 1 skill(s)
ℹ️ [implementation-brainstorming] 📊 implementation-brainstorming: 845 BPE tokens [chars/4: 982] (detailed ✓), 9 sections, 1 code blocks
ℹ️ Found 1 agent(s)
ℹ️ Validated 1 agent(s)
ℹ️ ✅ All checks passed (1 skill(s), 1 agent(s))
Full validator output
Found 1 skill(s)
[implementation-brainstorming] 📊 implementation-brainstorming: 845 BPE tokens [chars/4: 982] (detailed ✓), 9 sections, 1 code blocks
Found 1 agent(s)
Validated 1 agent(s)
✅ All checks passed (1 skill(s), 1 agent(s))

@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 4 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 1
ℹ️ Info 0
Severity Rule File Line Match
🟠 package-exec-command docs/README.skills.md 31 | [acreadiness-assess](../skills/acreadiness-assess/SKILL.md)&lt;br /&gt;`gh skills install github/awesome-copilot acreadiness-assess` | Run the AgentRC readiness assessment on the curre

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@starlightretailceo

Copy link
Copy Markdown
Contributor Author

Risk scan note: the package-exec-command soft-gate finding points at docs/README.skills.md line 31 for acreadiness-assess, which is unchanged from current main. This PR only adds the generated implementation-brainstorming row later in the skills index; all required checks are green.

@aaronpowell aaronpowell removed the targets-main PR targets main instead of staged label Jun 26, 2026

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you find that this agent brings over using the built-in Plan agent with skills?

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

⚠️ Warnings or advisories found

Scope Checked
Skills 1
Agents 1
Total 2
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 1

Summary

Level Finding
ℹ️ Vally currently lints SKILL.md content. Agent files were detected but skipped:
Full linter output
### Linting skills/implementation-brainstorming
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: 'commander@15.0.0',
npm warn EBADENGINE   required: { node: '>=22.12.0' },
npm warn EBADENGINE   current: { node: 'v20.20.2', npm: '10.8.2' }
npm warn EBADENGINE }
npm warn deprecated prebuild-install@7.1.3: No longer maintained. Please contact the author of the relevant native addon; alternatives are available.
✅ implementation-brainstorming (3/3 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
    ✓ [orphan-files] No orphan files found across 1 skill(s).
        ✓ orphan-files: No references/ directory found — no orphans possible.

1 skill(s) linted, 1 passed

### Agent files detected (not linted by vally)
ℹ️ Vally currently lints SKILL.md content. Agent files were detected but skipped:
agents/implementation-brainstormer.agent.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent PR touches agents new-submission PR adds at least one new contribution skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants