Skip to content

Remove [[ link syntax from C# XSS sink #22095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d10c wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −11
Open

Remove [[ link syntax from C# XSS sink #22095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions csharp/ql/lib/semmle/code/csharp/security/dataflow/XSSSinks.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,6 @@ private Expr aspWrittenValue(AspInlineMember m) {
m.getMember().(Callable).canReturn(result)
}

private string makeUrl(Location l) {
exists(string path, int sl, int sc, int el, int ec |
l.hasLocationInfo(path, sl, sc, el, ec) and
result = "file://" + path + ":" + sl + ":" + sc + ":" + el + ":" + ec
)
}

/**
* A sink for writes to properties that are accessed in ASP pages.
*
Expand All @@ -208,10 +201,7 @@ private class AspxCodeSink extends Sink {

AspxCodeSink() { this.getExpr() = aspWrittenValue(inline) }

override string explanation() {
result =
"member is [[\"accessed inline\"|\"" + makeUrl(inline.getLocation()) + "\"]] in an ASPX page"
}
override string explanation() { result = "member is accessed inline in an ASPX page" }
}

/** A sink for the output stream associated with a `HttpListenerResponse`. */
Expand Down
Loading