Unified: Enable on Arm64 - #22478
Merged
Merged
Conversation
jketema
added
the
depends on internal PR
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documented packaging script still mislabels Arm64 builds as linux64.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
unified/BUILD.bazel — This enables the Bazel package path, but the documented unified/scripts/create-extractor-pack.sh… |
What changed in this PR
Enables building and packaging the Unified extractor on Linux Arm64.
Changes:
- Packages the real Unified extractor for Linux Arm64.
- Registers the Arm64 Swift toolchain.
| File | Description |
|---|---|
unified/BUILD.bazel |
Enables the Arm64 extractor binary. |
MODULE.bazel |
Exposes and registers the Arm64 Swift toolchain. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| exes = codeql_platform_select( | ||
| linux64 = ["//unified/extractor"], | ||
| linux_arm64 = ["//unified/extractor-unsupported-os:extractor"], | ||
| linux_arm64 = ["//unified/extractor"], |
Contributor
Author
There was a problem hiding this comment.
Fair, but these are broken all over the place. We should probably find a way to get rid of most or all of them.
redsun82
reviewed
Sep 1, 2026
Comment on lines
44
to
48
| exes = codeql_platform_select( | ||
| linux64 = ["//unified/extractor"], | ||
| linux_arm64 = ["//unified/extractor-unsupported-os:extractor"], | ||
| linux_arm64 = ["//unified/extractor"], | ||
| osx64 = ["//unified/extractor"], | ||
| win64 = ["//unified/extractor-unsupported-os:extractor"], |
Contributor
There was a problem hiding this comment.
at this point we can simplify to
exes = codeql_platform_select(
win64 = ["//unified/extractor-unsupported-os:extractor"],
otherwise = ["//unified/extractor"],
),
Contributor
Author
There was a problem hiding this comment.
Let me get this merged and do a small follow-up.
redsun82
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.