fix: fall back to feature dir basename for empty CURRENT_BRANCH (#3026)

[Noor-ul-ain001]

What

When a feature is resolved via SPECIFY_FEATURE_DIRECTORY or .specify/feature.json without SPECIFY_FEATURE set, get_current_branch() returns empty, so get_feature_paths / Get-FeaturePathsEnv emitted CURRENT_BRANCH= (empty) / BRANCH: "" even though the feature directory was fully resolvable. Downstream scripts and agents that expect a non-empty identifier got misleading, silent empty output.

Fixes #3026.

How

Fall back to the basename of the resolved feature directory when the branch is empty, in both resolvers:

• bash (scripts/bash/common.sh): current_branch="${feature_dir##*/}"
• PowerShell (scripts/powershell/common.ps1): $currentBranch = Split-Path -Leaf $featureDir

An explicit SPECIFY_FEATURE still takes precedence (it's read before this fallback), so this only fills the previously-empty case — no change for users who set the feature explicitly.

Verification

Reproduced end-to-end (bash), with SPECIFY_FEATURE unset and the feature pinned in feature.json:

=== BEFORE FIX ===  BRANCH= ''
=== AFTER FIX  ===  BRANCH= '001-my-feature'
=== AFTER FIX (SPECIFY_FEATURE=my-branch override) ===  BRANCH= 'my-branch'

Tests

Added regression tests (bash + PowerShell) to tests/test_check_prerequisites_paths_only.py:

• (test_|test_ps_)current_branch_falls_back_to_feature_dir_basename — BRANCH equals the feature dir basename when SPECIFY_FEATURE is unset.
• test_explicit_feature_still_overrides_basename — SPECIFY_FEATURE remains authoritative.

Verified the PowerShell test fails on main (empty BRANCH) and passes with the fix; existing paths-only tests still pass; ruff clean. (Bash tests run on CI; they skip on my local Windows pytest env where bash isn't on the pytest PATH, but I reproduced the bash behavior directly as shown above.)

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR fixes a paths-only resolution edge case where feature context is resolvable (via SPECIFY_FEATURE_DIRECTORY or .specify/feature.json) but SPECIFY_FEATURE is unset, causing CURRENT_BRANCH/BRANCH to be emitted as an empty string. It adds a fallback that uses the resolved feature directory’s basename as a usable identifier, and introduces regression tests covering the behavior.

Changes:

• Bash: fall back to FEATURE_DIR basename when get_current_branch() is empty in get_feature_paths().
• PowerShell: apply the same basename fallback in Get-FeaturePathsEnv.
• Tests: add bash + PowerShell regression tests to assert the fallback behavior and that explicit SPECIFY_FEATURE remains authoritative.

Show a summary per file

File	Description
scripts/bash/common.sh	Adds CURRENT_BRANCH fallback to the resolved feature directory basename when explicit branch context is absent.
scripts/powershell/common.ps1	Adds the same fallback for CURRENT_BRANCH in the PowerShell resolver.
tests/test_check_prerequisites_paths_only.py	Adds regression tests validating the basename fallback and explicit override behavior for both bash and PowerShell.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 2
• Review effort level: Low

[mnriem]

Please address Copilot feedback

[Copilot]

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Low

[Copilot]

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 2
• Review effort level: Low

[mnriem]

Please address Copilot feedback. If not applicable, please explain why

[Noor-ul-ain001]

@mnriem i have commit copilot suggestions.

[Copilot]

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Low

[mnriem]

Please address Copilot feedback. If not applicable, please explain why

[Copilot]

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Low

[mnriem]

Please address Copilot feedback

[Noor-ul-ain001]

@mnriem i have resolved conversation with copilot

[mnriem]

Did you address the feedback and commit it? I am not seeing it?

[Noor-ul-ain001]

@mnriem Apologies for the confusion — earlier I only resolved the review threads in the UI without pushing a follow-up commit, so there was nothing new for you to see. That's now fixed in commit d3b0f69, which addresses the remaining Copilot feedback:

1. PowerShell trailing-slash fix was broken on Windows PowerShell 5.1. The Copilot autofix used [System.IO.Path]::TrimEndingDirectorySeparator(...), which is a .NET Core / .NET 5+ only API. On Windows PowerShell 5.1 (.NET Framework) it throws MethodNotFound, breaking the script whenever the basename fallback runs. I replaced it with a portable $featureDir.TrimEnd('/', '\'), which works on both 5.1 and 7+. Verified on powershell.exe 5.1 locally.
2. Parametrized the bash fallback test to cover all three sources/cases — feature.json, SPECIFY_FEATURE_DIRECTORY, and the explicit SPECIFY_FEATURE override — mirroring the PowerShell test (folded in the old test_explicit_feature_still_overrides_basename).
3. Added the missing blank line (PEP 8) between the parametrized PowerShell test and the following test.

Local run: 8 passed, 7 skipped (bash tests skip only because bash isn't on my local pytest PATH — they run on CI). Thanks for your patience.

[Copilot]

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 0 new
• Review effort level: Low