Repository navigation
fix: set HttpOnly on the JWT removal cookie in Reset - #320
Merged
Merged
Conversation
Set writes the JWT cookie with HttpOnly and Reset expired it without. Chromium rejects any Set-Cookie for a __Http- or __Host-Http- prefixed name that lacks HttpOnly, the expiry included, so with such a JWTCookieName logout left the session cookie in place. With PartitionedCookies on, the unpartitioned form was cleared and the partitioned one survived. the removal header gains "; HttpOnly" for every deployment. Cookie identity is name, domain and path, so it still replaces the cookie.
Coverage Report for CI Build 38161668714Coverage increased (+0.004%) to 86.88%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resetnow expires the JWT cookie withHttpOnly, same asSetwrites it, in both modules.Chromium rejects any
Set-Cookiefor a__Http-or__Host-Http-prefixed name withoutHttpOnly, the expiry included. With such aJWTCookieNamelogout left the session cookie in place. WithPartitionedCookieson, the unpartitioned form was cleared by the legacy expiry and the partitioned one survived.the removal header gains
; HttpOnlyfor every deployment. Cookie identity is name, domain and path, so it still replaces the cookie, andTestJWT_Resetpins the new header.found while reviewing #318.