Repository navigation
Conversation
MaxKeys(0) means unlimited. A negative value previously set maxKeys to a negative number, which also disabled the size limit because the eviction check only runs when maxKeys > 0. That made MaxKeys(-1) look like a successful configuration while silently ignoring the intended cap. Return an error from the MaxKeys option when the value is negative.
|
closing this and the other go-pkgz PRs from the same batch without merging. I won't even bother reviewing them, it is not worth the time spent. this one breaks back compatibility. this is also one of about 200 PRs you opened across unrelated repos in about 80 minutes today. That is a fishing expedition, spaghetti thrown at the wall to see what sticks, and every piece of it costs me time to read and close. I have nothing against AI-assisted work, and real users of these libraries are welcome, but nobody asked for any of this and it is a waste of my time. Stop doing it in my repos. |
Summary
MaxKeys(0)means unlimited. A negative value previously stored a negativemaxKeys, and because eviction only runs whenmaxKeys > 0,MaxKeys(-1)silently behaved like unlimited instead of failing closed.Return an error from the
MaxKeysoption when the value is negative.Test plan
TestMaxKeysRejectsNegativego test .