Repository navigation
return a lone pool error without a join - #15
Merged
Merged
Conversation
waitWorkers joined the errgroup result with the completion error on every path, so a single worker error came back as a one-element join and errors.Unwrap on the result of Close or Wait returned nil where it used to return the inner error. a lone error is now returned as is, and the two are joined only when both are set.
…DE.md the error handling notes still said the pool completion callback is skipped only on context.Canceled, which reads as the old lastErr check. It is skipped only when the context passed to Go was cancelled. also notes that go mod tidy in an example has to run with the replace line removed, or it drops the pool checksums from go.sum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after #13
waitWorkersjoined the errgroup result with the completion error on every path, so a single worker error came back fromCloseandWaitas a one-element join.errors.Isanderrors.Asstill matched, buterrors.Unwrapreturned nil where it used to return the inner error. A lone error is now returned as is, and the two are joined only when both are set.the other two commits are notes: CLAUDE.md gets the current rule for when the completion callback is skipped and the go.sum step for bumping examples, and
docs/backlog/gets three items left over from the review of #13.