Repository navigation
Keep the caller's receipt header on UNSUBSCRIBE - #162
Closed
mkuratczyk wants to merge 1 commit into
Closed
mkuratczyk wants to merge 1 commit into
mkuratczyk wants to merge 1 commit into
Conversation
processLoop replaced any receipt header on an UNSUBSCRIBE frame with the subscription id. sendFrame had already registered a waiter under the caller's receipt id, so that waiter never got its RECEIPT and Unsubscribe blocked until the connection closed. Keep the caller's receipt and, when its RECEIPT arrives, complete both the waiter and the subscription channel.
Collaborator
|
I believe this commit is already in #161 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processLoop replaced any receipt header on an UNSUBSCRIBE frame with the subscription id. sendFrame had already registered a waiter under the caller's receipt id, so that waiter never got its RECEIPT and Unsubscribe blocked until the connection closed.
Keep the caller's receipt and, when its RECEIPT arrives, complete both the waiter and the subscription channel.