Repository navigation
chore: anchor ignore rules, remove pre-release-check.sh - #115
Merged
Merged
Conversation
Ignore rules that were bare names (INDEX.md, test_*, QUICK_START*.md, RESEARCH*.md, gops_config.yaml, project_docs_*.md) matched in every directory and could hide public files; INDEX.md hid docs/INDEX.md. The scratch and generator patterns now apply to the root only, and INDEX.md is no longer ignored. Private directories stay ignored by directory: .claude/ and .pm/ (new) anywhere, /tmp/, /docs/dev/. Also ignore binaries built in an example directory (they have no extension), *.prof, coverage.* and go.work.sum.
The script duplicated the CI jobs and had drifted from them; its own comments carried a path of the maintainer's machine. CONTRIBUTING.md now lists the checks CI runs: format, lint on every target, tests and the race detector.
kolkov
added
type: docs
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two housekeeping changes.
Ignore rules. Several rules in
.gitignorewere bare file names (INDEX.md,test_*,QUICK_START*.md,RESEARCH*.md,gops_config.yaml,project_docs_*.md). A bare name matches in every directory, so it can hide a public file anywhere in the tree;INDEX.mdhiddocs/INDEX.md. The scratch and generator patterns now apply to the repository root only, andINDEX.mdis no longer ignored. Private directories stay ignored by directory (.claude/and the new.pm/anywhere,/tmp/,/docs/dev/). Binaries built in an example directory, which have no extension, are ignored now, as are*.prof,coverage.*andgo.work.sum.Checked: no tracked file becomes ignored (
git ls-files -i -c --exclude-standardprints nothing).examples/*/main.go,structlib.candgo.modstay visible.examples/struct/struct-example,ffi/testdata/libstructtest.so,coverage.outandcpu.profare ignored.scripts/pre-release-check.shremoved. It duplicated the CI jobs and had drifted from them.CONTRIBUTING.mdnow lists the checks CI runs: format, lint on every target, tests and the race detector.ROADMAP.mdno longer mentions the script.