Repository navigation
test(textfield): cover drag selection - #249
Merged
Merged
Conversation
The gesture path already extended a selection while dragging (ADR-049), but nothing tested it at the widget level: only the double and triple click paths had tests. The test presses at the first rune, drags past the last one and asserts the whole text is selected during the drag and after the release. Related: #225.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing widget-level test for text selection by dragging, the last part of #225 without one. Double-click word selection and triple-click select-all were already covered (
TestMouse_DoubleClickSelectsWord,TestMouse_TripleClickSelectsAll); the drag path went through the gesture recognizer with no test at this level.The test presses at the first rune, makes a move past the drag slop (which starts the drag), drags past the last rune, and asserts the selection is the whole text both during the drag and after the release. If the drag callbacks did nothing, the selection would stay collapsed at 0 and the assertions would fail.
The feature itself shipped in v0.1.54; this only locks it in. Test-only change, no CHANGELOG entry.