Repository navigation
fix(dialog): lay out the content widget before drawing it - #250
Merged
Merged
Conversation
The surface drew its content without ever laying it out. A single Text worked because it draws from its own bounds, but a container such as primitives.HBox kept all of its children at empty bounds, so TextWidget.Draw returned early on them and the dialog showed nothing (#241). computeDialogBounds now lays the content out within the dialog width, and the measured height is part of the dialog height instead of the fixed padding allowance. The test fails on the old code: both box children keep empty bounds and only the title is drawn.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #241.
The dialog surface drew its content without ever laying it out. A single
Textlooked fine because it draws from its own bounds, but a container such asprimitives.HBoxkept its children at empty bounds, andTextWidget.Drawreturns early on those — so the user saw an empty dialog.computeDialogBoundsnow lays the content out within the dialog width, and the measured height is part of the dialog height instead of the fixed padding allowance, so taller content also gets the room. Layout happens in the same place the dialog already measured its action buttons (draw time), so the overlay path keeps its current shape.The new test builds a dialog with an
HBoxof two labels and draws it. On the old code it fails exactly as the issue describes: both children keep empty bounds and only the title is drawn. With the fix both labels get bounds and are drawn.Checked locally with
GOWORK=off: dialog, primitives and app tests pass, build and lint clean.