Repository navigation
docs(readme): claims that match the code, and an acknowledgment of gfx-rs/wgpu - #385
Merged
Merged
Conversation
…x-rs/wgpu Every claim was checked against the code, the tests and CI: - ErrMapCanceled is the error's name (was ErrMapCancelled). - Vulkan on macOS is not run in CI (no MoltenVK on the runner): Untested. Metal runs on the macOS runner's virtual GPU. - The software rasterizer lists what the draw path does. The tile-based parallel rasterizer is used only by tests and benchmarks, clip-space clipping is not done yet, and the known gaps are named. - The -tags rust build is not usable for real rendering with go-webgpu/webgpu v0.5.5 (0.34.6 known issue). - No 'first' claims, no 'full' or 'battle-tested' without evidence; StagingBelt no longer claims zero allocation (no benchmark backs it). - An Acknowledgments section thanks the authors of gfx-rs/wgpu, whose architecture wgpu follows.
… from webgpu v0.34.8 shipped shared workgroup memory and real barriers on software (P1-SW-025), so it is no longer a known gap. The -tags rust note now says what go-webgpu/webgpu v0.5.5 does on each platform, as its maintainers describe it: an abort at adapter request on Linux amd64 and Intel macOS, and vertex buffer, depth attachment and bind group layout failures on Windows.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through the README claim by claim against the code, the tests and what CI actually runs, and fixed what didn't hold:
ErrMapCanceledis the error's real name (the README saidErrMapCancelled).-tags rustwith go-webgpu/webgpu v0.5.5 isn't usable for real rendering yet (the 0.34.6 known issue). The README now says so.BenchmarkBufferMapReadPrimaryshows 0 allocs/op.README only, no code changes.