[bot] Merge master/f8f72561 into rel/dev#1684
Merged
Merged
Conversation
agent_alert_skill scored trigger_correct=False for "Every time" cases when the
agent omitted the trigger argument. create_metric_alert serialises an unset
trigger as `trigger: null`, so `dict.get("trigger", "ALWAYS")` returned None
instead of the ALWAYS product default. Default a missing OR null trigger to
ALWAYS in both the agentic runner (_check_trigger) and AlertSkillEvaluator, and
add regression tests. A genuinely wrong trigger (e.g. ONCE_PER_INTERVAL when
ONCE is expected) still fails.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…-always fix(eval): treat missing/null alert trigger as ALWAYS default
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1684 +/- ##
===========================================
+ Coverage 77.80% 77.85% +0.04%
===========================================
Files 271 271
Lines 18602 18603 +1
===========================================
+ Hits 14474 14483 +9
+ Misses 4128 4120 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to f8f7256 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/28929649916).