Copybara import of the project: - #11080
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
-- 61f8d81 by destro4evr-rgb <destro4evr@proton.me>: litert/xnnpack: guard against 0D scalar axes/begin tensor in Mean and Slice MeanOperation::ToXnnpack() accesses axes_info.shape[0] and SliceOperation::ToXnnpack() accesses begin_info.shape[0] without checking whether the shape vector is empty. A crafted TFLite model that declares either tensor as a 0D scalar produces an empty shape vector; operator[](0) on an empty std::vector dereferences null -> SIGSEGV during XNNPACK subgraph compilation at model load time. Add shape.empty() guards matching the pattern already used in ExpandDimsOperation::ToXnnpack() and in the keep_dims branch of Mean() in litert/tensor/arithmetic.h. FUTURE_COPYBARA_INTEGRATE_REVIEW=#11056 from destro4evr-rgb:fix/litert-mean-slice-shape-empty-null-deref 61f8d81 PiperOrigin-RevId: 971398840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara import of the project:
--
61f8d81 by destro4evr-rgb destro4evr@proton.me:
litert/xnnpack: guard against 0D scalar axes/begin tensor in Mean and Slice
MeanOperation::ToXnnpack() accesses axes_info.shape[0] and
SliceOperation::ToXnnpack() accesses begin_info.shape[0] without checking
whether the shape vector is empty. A crafted TFLite model that declares
either tensor as a 0D scalar produces an empty shape vector; operator
on an empty std::vector dereferences null -> SIGSEGV during XNNPACK subgraph
compilation at model load time. Add shape.empty() guards matching the pattern
already used in ExpandDimsOperation::ToXnnpack() and in the keep_dims branch
of Mean() in litert/tensor/arithmetic.h.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#11056 from destro4evr-rgb:fix/litert-mean-slice-shape-empty-null-deref 61f8d81