Repository navigation
Conversation
…as is unset The override was resolved with `_parse_bool(A) or _parse_bool(B)`. With A explicitly false and B unset that evaluates to None, so the override was dropped and automatic tool detection kept recording enabled. Collect the values that are set and apply them; for conflicting aliases an explicit true still wins, as before. Fixes google#202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARTEMIS_VIDEO_RECORDING_ENABLEDandARTEMIS_WITH_VIDEO_RECORDING_TOOLSwere combined with_parse_bool(A) or _parse_bool(B). When A is explicitlyfalseand B is unset,False or NoneisNone, so the override was dropped: video stayed on if scrcpy/FFmpeg were detected, and an explicitvideo_analyzer.enabled=truein the config file was not overridden.This now takes the values that are set, and uses
any()of them. A lonefalseis applied to bothvideo_analyzerandpro.video_analyzer. The conflicting-alias cases keep their previous result (an explicit true wins), and nothing changes when neither variable is set.Added a parametrized test in
tests/unit/test_config_package.pycovering false/unset, unset/false, false/false, true/unset, unset/true and both conflicting orders. The false/unset row fails without the fix.tests/unit/test_config_package.py: 40 passed.Fixes #202