Repository navigation
Conversation
…IS_OPENAI_RESPONSES_API) Some OpenAI-compatible endpoints only accept function tools on /v1/responses (GPT-6.x on Amazon Bedrock). A regex on the model name selects langchain's use_responses_api for those models; nothing changes when unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some OpenAI-compatible endpoints accept function tools only on the Responses API. One example is GPT-6.x on Amazon Bedrock, whose
/v1/chat/completionsrejects tools combined with reasoning. Withprovider: "custom", ARTEMIS always builds a Chat Completions client, so those models cannot run the Flash operator.This PR adds an opt-in,
ARTEMIS_OPENAI_RESPONSES_API, which takes a regex matched against the model name. For a matching model, the custom/vLLM/Ollama branch ofModelFactorypassesuse_responses_api=TruetoChatOpenAI. When the variable is unset or doesn't match, nothing changes.An environment variable keeps the change to one line in the factory and leaves the config schema alone. I'm happy to move it into the endpoint config instead if you prefer.
Tests
The new file
tests/unit/test_model_factory_responses_api.pycovers three cases: a matching model opts in, a non-matching model keeps Chat Completions, and an unset variable changes nothing.make test,make lintandmake typecheckpass.