Repository navigation
fix(config): keep validator_pixel_safety_net and planner_validation overrides - #222
Open
macrocrazier wants to merge 1 commit into
Open
macrocrazier wants to merge 1 commit into
macrocrazier wants to merge 1 commit into
Conversation
…verrides _expand_default_into_nodes only copied its fixed list of agent nodes, so overrides for the two optional judge nodes were silently dropped and get_agent() fell back to the Google flash-lite default. Pass both nodes through when declared, merged over the default; leave them unset otherwise so the lightweight default still applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LLMConfigdeclares two optional judge nodes,validator_pixel_safety_netandplanner_validation. If they are configured undernodesinartemis.jsonc, the overrides are silently dropped, andget_agent()falls back tolightweight_judge_default(), which is a Google flash-lite model.With a non-Google setup and no Google key, the pixel safety net then fails to initialize and is skipped. The log shows
'LLMConfig' object has no attribute 'validator', and nothing says the configured model was ignored.Cause
_expand_default_into_nodes()only copies the nodes in its fixedall_agent_nodeslist into the expanded config. The two optional judge nodes are not in that list.Fix
Pass the two judge nodes through when they are declared, merged over
default, like other nodes. When they are not declared, they stay unset, so the existing lightweight default still applies.Tests
New
tests/unit/config/test_llm_judge_nodes.py:mainand passes with this change.lightweight_judge_default().make test: no new failures compared withmain.make lintandmake typecheckpass.Related: #138, #179 (other places where a non-Google configuration still reaches Gemini).