Repository navigation
Enable IPv6 address-family selection in Cisco ASA headers - #375
Open
Shubham-Padkonde wants to merge 2 commits into
Open
Shubham-Padkonde wants to merge 2 commits into
Shubham-Padkonde wants to merge 2 commits into
Conversation
kevinkrk-slac
left a comment
kevinkrk-slac
left a comment
There was a problem hiding this comment.
I need this feature.
It appears to be stuck waiting for a maintainer.
|
It would be nice if this supported the "mixed" keyword like the Cisco generator does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ASA generator always created IPv4 terms, preventing IPv6 address and ICMPv6 output. This adds
target:: ciscoasa <name> inet6andmixed, while preserving the default or explicitinetbehavior.IPv6 output uses
any6andicmp6. Mixed mode emits each term's IPv4 and IPv6 rules before proceeding to the next term, withany4/any6wildcards. ICMP types stay with their matching protocol family. Verbatim rules are emitted once, and rendering both families does not mutate shared owner comments. Invalid family combinations are rejected; the generator documentation describes the syntax and ASA 9.0+ requirement.Fixes #252.
Validation: all 1,726 tests and 15 subtests pass. All three new mixed-mode tests fail on the preceding PR head. The final focused run passes 11 tests and two subtests. Pylint reports existing configuration/style findings; comparison with the preceding head finds no additional findings. No live ASA appliance was available. Syntax was checked against Cisco's extended ACL documentation.