reject out-of-range POSIX offsets in GetTransitionType - #369
Open
rajath201 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimeZoneInfo::Load rejects any file-supplied transition type whose UTC offset is a day or more from UTC (
utc_offset >= kSecsPerDay || <= -kSecsPerDay), but the types built from a version-2+ TZif POSIX footer never hit that bound. ParsePosixSpec accepts an std/dst offset field up to 24:59:59, so a footer likeEST5EDT24:30:00,M3.2.0,M11.1.0loads fine and its summer lookups return an offset of -88200s (24.5h) that the binary reader would have refused.GetTransitionType is the one spot where the POSIX path turns an offset into a stored type, so the same range check goes there and covers both the std and dst offsets. Keeping it in the shared helper instead of ExtendTransitions avoids validating the default dst offset of a std-only spec, which is never stored.