Repository navigation
Fix GEP-from-GEP merge across struct boundary - #1699
Open
carbotaniuman wants to merge 2 commits into
Open
carbotaniuman wants to merge 2 commits into
carbotaniuman wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
carbotaniuman
force-pushed
the
fix-gep-from-gep-struct-array
branch
from
October 23, 2026 03:12
d247304 to
dfc04d9
Compare
runOnGEPFromGEP folds a constant GEP into a preceding GEP, but this
merged GEP may be outside the bounds of the struct, leading to issues.
This is reachable from OpenCL C.
typedef struct { ushort x, y; } P;
kernel void k(global P *out, ushort y, uint i) {
P pts[2];
pts[0].y = y;
out[0] = pts[i];
}
carbotaniuman
force-pushed
the
fix-gep-from-gep-struct-array
branch
from
October 23, 2026 04:58
dfc04d9 to
43690b3
Compare
rjodinchr
reviewed
Oct 23, 2026
rjodinchr
left a comment
rjodinchr
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching and fixing this issue! The fix and tests look good overall; I just left two suggestions to reuse existing helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runOnGEPFromGEP folds a constant GEP into a preceding GEP, but this merged GEP may be outside the bounds of the struct, leading to issues.
This is reachable from OpenCL C.
typedef struct { ushort x, y; } P;
kernel void k(global P *out, ushort y, uint i) {
P pts[2];
pts[0].y = y;
out[0] = pts[i];
}