util/resolve: sort versions in APIClient.Versions - #387
Merged
Conversation
cuixq
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #385.
Supersedes #386 (closed after a head-branch rename)
Continuing the review thread with @cuixq, who suggested sorting at the API client layer and documenting on
Client.Versionsthat the versions should be sorted.Problem
APIClient.Versionsreturned versions in the order returned by the deps.dev API, which is not ascending (for PyPI, at least, it is lexicographic, where "9.1.0" comes after "84.0.0"). The PyPI resolver iterates the version list in descending order, relying on it being sorted ascending, so unpinned transitive requirements resolved to the lexicographic maximum (e.g.setuptools 9.1.0instead of84.0.0).Fix
Sort the versions in
APIClient.Versions, the layer that converts the API response, and document the ordering contract onClient.Versions.Test
TestVersionsfeeds a lexicographically ordered PyPI version list toAPIClient.Versionsand asserts the ascending order, and verified the test fails without the fix.