[C++] Fix NULL pointer dereference in reflection VerifyVector() (union vector, CWE-476) - #9228
[C++] Fix NULL pointer dereference in reflection VerifyVector() (union vector, CWE-476)#9228thinhnallf wants to merge 2 commits into
Conversation
…n vector, CWE-476) VerifyVector()'s reflection::Union case can dereference a NULL type_vec pointer when a FlatBuffer's vtable has the union value-vector field present but the (implicit) companion type-vector field's slot absent. VerifierTemplate::VerifyVector(nullptr) intentionally returns true (a null vector is a valid, absent optional field), so a null type_vec is not rejected by the existing VerifyVector(type_vec) check, and the very next line dereferenced it unconditionally. Related to, but distinct from, google#8567 (already fixed): that issue was about a length mismatch between two non-null vectors; its fix added the size comparison seen here but never added a null-check for type_vec itself.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@googlebot check |
|
Bug
In
src/reflection.cpp, thereflection::Unioncase insideVerifyVector()can encounter a null pointer dereference iftype_vecis null.Since
VerifierTemplate::VerifyVector(nullptr)intentionally returnstrue(as a null vector represents a valid, absent optional field), a nulltype_vecsafely passes the verification line but subsequently causes an unconditional null pointer dereference during the size comparison.Fix
Add an explicit null-check for
type_vecimmediately after the verification check, before it is dereferenced.Testing
Confirmed locally that handling an absent companion type-vector field no longer causes a crash and is now correctly rejected by returning
false.