Fix build non-determinism in J2ObjC code generator.#2807
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix build non-determinism in J2ObjC code generator.#2807copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
When transpiling Java code to Objective-C via J2ObjC (rule J2objcTranspile), build output could differ across runs due to two issues: 1. Unordered HashSet instances were used for collecting types, forward declarations, and variables in HeaderImportCollector, ObjectiveCImplementationGenerator, ObjectiveCHeaderGenerator, and VariableRenamer. Using HashSet on TypeElement, VariableElement, TypeMirror, and Import resulted in non-deterministic iteration order based on identity hash codes. 2. When relative line directives (-g:relative) were enabled, temporary extraction directory paths (/tmp/<random_temp_dir>/...) were emitted into #line directives because /tmp/ paths failed startsWith(cwdPath). This CL replaces HashSet with LinkedHashSet across these generator passes and updates TypeImplementationGenerator.getSourceFilePath() to strip temporary directory prefixes when -g:relative is set. PiperOrigin-RevId: 951131076
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build non-determinism in J2ObjC code generator.
When transpiling Java code to Objective-C via J2ObjC (rule J2objcTranspile), build output could differ across runs due to two issues:
This CL replaces HashSet with LinkedHashSet across these generator passes and updates TypeImplementationGenerator.getSourceFilePath() to strip temporary directory prefixes when -g:relative is set.