fix: log path-like subprocess arguments without raising - #1041
Closed
Shubham-Padkonde wants to merge 1 commit into
Closed
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Collaborator
|
Closing this PR. We do not accept AI-generated PRs targeting synthetic edge cases that contradict our documented API contracts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_commandaccepts arguments supported bysubprocess.Popen, but its final debug-log formatting passes each argument directly toshlex.quote. Apathlib.Pathexecutable therefore runs successfully and then raisesTypeErrorinstead of returning its result.Decode bytes and path-like arguments with
os.fsdecodewhen constructing the display string, including standalone commands. The original arguments passed to the subprocess are unchanged. Tests cover mixed argument types and a real Python subprocess invoked through aPath.Validation: both new regressions fail before the fix. Full Mobly suite: 826 passed, 5 skipped; 12 destructor warnings report unavailable ADB during snippet-client cleanup. Pyink 24.3.0 and
git diff --checkpass.