refactor(go-website): implement non-datastore dev server for testing - #5843
Open
michaelkedar wants to merge 2 commits into
Open
refactor(go-website): implement non-datastore dev server for testing#5843michaelkedar wants to merge 2 commits into
michaelkedar wants to merge 2 commits into
Conversation
michaelkedar
changed the title
michaelkedar
force-pushed
the
web-emu
branch
2 times, most recently
from
August 24, 2026 05:53
7bcafe9 to
5197390
Compare
michaelkedar
force-pushed
the
web-emu
branch
2 times, most recently
from
August 25, 2026 02:03
3f0ff83 to
5197390
Compare
another-rex
reviewed
Aug 27, 2026
| continue | ||
| } | ||
|
|
||
| vuln, _, err := readRecordFromFile(filepath.Join(ds.dataDir, entry.Name())) |
Contributor
There was a problem hiding this comment.
If this errors, can we log an error?
| pageSize = 16 | ||
| } | ||
|
|
||
| // Cursor and legacy pagination |
Contributor
There was a problem hiding this comment.
Hm? why do we need legacy pagination here. Is this just the best way to paginate locally?
Contributor
There was a problem hiding this comment.
If so please update the comment explaining why.
| // models.VulnerabilitySearchStore Implementation | ||
| // ========================================================================= | ||
|
|
||
| func (ds *DevStore) Search(_ context.Context, query models.VulnerabilitySearchQuery) (*models.VulnerabilitySearchResult, error) { |
Contributor
There was a problem hiding this comment.
as far as I can tell this doesn't search for repos names (this is something datastore indexes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This serves the same function as
run-website-emulator, but doing it with implementations of theXyzStoreinterfaces to read and serve vulnerability JSON files from disk.This way, we can test the website without needed to spin up the datastore (and gcs) emulator, and without having to populate every datastore tables.
The vuln json files (and metadata yaml files) should be able to be hot-loaded, which should make testing easier.
The code assumes that aliases, upstream, related are all fully computed in the vulnerability JSON - it does not the the transitive alias/upstream calculations.
Stack created with GitHub Stacks CLI • Give Feedback 💬