tp: validate variant column types - #7167
Draft
LalitMaganti wants to merge 1 commit into
Draft
Conversation
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 21, 2026 13:33
0678132 to
147ef70
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 13:34
62f4dcd to
0ff9bcb
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 21, 2026 13:43
147ef70 to
873a588
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 13:43
0ff9bcb to
2f056ac
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 21, 2026 13:52
873a588 to
5876d07
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 13:53
2f056ac to
98d4d5e
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 21, 2026 14:23
5876d07 to
b3fdc90
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 14:23
98d4d5e to
2298a36
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 21, 2026 15:12
b3fdc90 to
ba10a53
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 15:12
2298a36 to
a22a502
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 21, 2026 15:21
ba10a53 to
b670ed5
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 15:21
a22a502 to
c6f181b
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 21, 2026 15:33
b670ed5 to
6738e6b
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 15:33
c6f181b to
129d977
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 21, 2026 16:18
6738e6b to
453bd8d
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 16:18
129d977 to
0b6d57b
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 25, 2026 13:49
453bd8d to
9f295f9
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 25, 2026 13:49
0b6d57b to
f4294d4
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-fold
branch
from
August 25, 2026 13:54
9f295f9 to
f011e48
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 25, 2026 13:54
f4294d4 to
cf16806
Compare
LalitMaganti
changed the base branch from
dev/lalitm/exec-tree-fold
to
dev/lalitm/exec-sql-scan
August 25, 2026 14:21
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 25, 2026 14:21
cf16806 to
55c4eda
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-sql-scan
branch
from
August 25, 2026 14:59
db06cd9 to
33deaa4
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
2 times, most recently
from
August 25, 2026 16:50
c8236f9 to
5433d52
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-sql-scan
branch
2 times, most recently
from
August 26, 2026 16:44
31e8cae to
d380360
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 26, 2026 16:44
5433d52 to
1ebee64
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-sql-scan
branch
from
August 26, 2026 17:05
d380360 to
75812b7
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 26, 2026 17:05
1ebee64 to
9e9fec6
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-sql-scan
branch
from
August 26, 2026 17:13
75812b7 to
c0d97d6
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 26, 2026 17:13
9e9fec6 to
d603214
Compare
A SqlScan column uses Variant when lineage cannot prove one storage type. Typed operators need to check those values before reading them as a flat column. AssertType checks every selected row against the requested type and produces a flat column. Nulls remain null. Narrow integers can widen when the conversion is exact; other mismatches stop the pipeline and name the offending column. This is an operator rather than part of SqlScan because the consumer, not the source, decides what type a column must have.
LalitMaganti
force-pushed
the
dev/lalitm/exec-sql-scan
branch
from
August 26, 2026 17:39
c0d97d6 to
d1cbe41
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 26, 2026 17:39
d603214 to
d3ade1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A SqlScan column uses Variant when lineage cannot prove one storage type.
Typed operators need to check those values before reading them as a flat
column.
AssertType checks every selected row against the requested type and produces a
flat column. Nulls remain null. Narrow integers can widen when the conversion
is exact; other mismatches stop the pipeline and name the offending column.
This is an operator rather than part of SqlScan because the consumer, not the
source, decides what type a column must have.