protozero: remove Append() and its fastpath - #7267
Draft
LalitMaganti wants to merge 1 commit into
Draft
Conversation
🎨 Perfetto UI Builds
|
LalitMaganti
force-pushed
the
dev/lalitm/zerocopy-4-drop-append
branch
from
August 28, 2026 01:40
4f9cf69 to
3d392e0
Compare
primiano
approved these changes
Aug 28, 2026
LalitMaganti
force-pushed
the
dev/lalitm/zerocopy-4-drop-append
branch
from
August 28, 2026 14:30
3d392e0 to
c575f83
Compare
LalitMaganti
force-pushed
the
dev/lalitm/zerocopy-4-drop-append
branch
from
August 28, 2026 15:10
c575f83 to
a411ee2
Compare
LalitMaganti
force-pushed
the
dev/lalitm/zerocopy-4-drop-append
branch
from
August 28, 2026 15:31
a411ee2 to
14a7bf4
Compare
LalitMaganti
force-pushed
the
dev/lalitm/zerocopy-4-drop-append
branch
from
August 28, 2026 15:32
14a7bf4 to
618e203
Compare
LalitMaganti
marked this pull request as draft
August 28, 2026 15:34
Append()'s fastpath returned messages pointing into the caller's buffer, valid only until the next call. That is why RemoteTraceProcessor had to hoist its read buffer out of the loop, and it is what stops a Message from owning its storage. Every caller now writes through BeginWrite(), so both can go. Also collapses RingBufferMessageReader into ProtoRingBuffer: the virtual had a single production implementation, and a test-only subclass whose coverage the ProtoRingBuffer tests subsume. The benchmarks added to motivate the switch go too: their "before" arm is the staging buffer this removes.
LalitMaganti
force-pushed
the
dev/lalitm/zerocopy-4-drop-append
branch
from
August 28, 2026 15:38
618e203 to
9a60ae5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append()'s fastpath returned messages pointing into the caller's buffer,
valid only until the next call. That is why RemoteTraceProcessor had to
hoist its read buffer out of the loop, and it is what stops a Message
from owning its storage. Every caller now writes through BeginWrite(),
so both can go.
Also collapses RingBufferMessageReader into ProtoRingBuffer: the virtual
had a single production implementation, and a test-only subclass whose
coverage the ProtoRingBuffer tests subsume.
The benchmarks added to motivate the switch go too: their "before" arm
is the staging buffer this removes.