ui: Add slider to control GPU counters collection - #7285
Open
staticfloat wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
On some platforms (e.g. mesa's `pps-producer`) collection at 10KHz can have a large CPU performance impact. Give the user an easy way to select a reasonable GPU counter collection rate, expressed in Hz similar to other collection rates such as stack sampling. Keep the default at 10KHz to not disturb existing users, but at least erase the comment claiming it is 10Hz.
staticfloat
force-pushed
the
sf/gpu_counter_slider
branch
from
August 28, 2026 22:12
1139c95 to
4773c1b
Compare
LalitMaganti
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms (e.g. mesa's
pps-producer) collection at 10KHz can have a large CPU performance impact. Give the user an easy way to select a reasonable GPU counter collection rate, expressed in Hz similar to other collection rates such as stack sampling.Keep the default at 10KHz to not disturb existing users, but at least erase the comment claiming it is 10Hz.