Fix hashed length calculation in get_file_sha256. - #236
Open
grrrrrrrrr wants to merge 1 commit into
Open
Conversation
When computing the SHA-256 digest with `offset > 0`, the action reported the hashed length via `file.stream_position()`. This returned the absolute stream position at EOF (`offset + bytes_read`) rather than the number of bytes actually read and hashed. This change directly accumulates the bytes read in the hashing loop and returns that value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When computing the SHA-256 digest with
offset > 0, the action reportedthe hashed length via
file.stream_position(). This returned the absolutestream position at EOF (
offset + bytes_read) rather than the number ofbytes actually read and hashed.
This change directly accumulates the bytes read in the hashing loop and
returns that value.